Fix TileSet property painter popup showing clear color #93609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passivestar
force-pushed
the
tileset-prop-popup-bg
branch
from
cedf85a to
02ec35b
Compare
passivestar
force-pushed
the
tileset-prop-popup-bg
branch
from
02ec35b to
44e2991
Compare
groud
approved these changes
Jun 28, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93278
This problem is usually handled in popups with a separate background panel, but in this case since there's already a panel in the Tree I used that instead. It's now using the same color as every other popup menu in the editor for consistency
Wasn't too sure what color to choose for group backgrounds because no other popup menu has sections like that and
prop_categoryis way to monochrome for the popup menu color. Would also feel weird to create and expose a new color just for this menu, so I went withseparator_colorfor now