Improve handling of rendering startup errors #93706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
force-pushed
the
fix_rend_misc
branch
from
bc19837 to
32d9c93
Compare
m4gr3d
approved these changes
Jun 29, 2024
|
Thanks! |
akien-mga
reviewed
Jun 29, 2024
| @@ -6261,8 +6261,14 @@ DisplayServerX11::DisplayServerX11(const String &p_rendering_driver, WindowMode | |||
|
|
|||
| #if defined(RD_ENABLED) | |||
| if (rendering_context) { | |||
| rendering_device = memnew(RenderingDevice); | |||
There was a problem hiding this comment.
You removed one line too many here... not sure why CI didn't complain, but then it broke once merged: https://github.com/godotengine/godot/actions/runs/9723676850/job/26839084653
There was a problem hiding this comment.
not sure why CI didn't complain
Seems like the CI never ran because GH was broken yesterday: https://www.githubstatus.com/incidents/9vwllhs2w1kj
I wish they'd make that more explicit before merging.
akien-mga
added a commit
that referenced
this pull request
Jun 29, 2024
The line was removed by mistake.
TV4Fun
pushed a commit
to TV4Fun/godot
that referenced
this pull request
Jul 2, 2024
The line was removed by mistake.
sorascode
pushed a commit
to sorascode/godot-soras-version
that referenced
this pull request
Jul 22, 2024
The line was removed by mistake.
Luis-Wong
pushed a commit
to Luis-Wong/godot
that referenced
this pull request
Jul 26, 2024
The line was removed by mistake.
2nafish117
pushed a commit
to 2nafish117/godot
that referenced
this pull request
Aug 5, 2024
The line was removed by mistake.
chryan
pushed a commit
to chryan/godot
that referenced
this pull request
Aug 6, 2024
The line was removed by mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
RenderingDevicestartup fail if staging buffers can't be created. Also allows any error in such initialization to take the engine through the path where it can handle it so it can eventually show the message box that suggests using GL ES 3, etc.Despite this, the engine still crashes after that (at least in my case and with a dev build). However, this is already a step forward so in cases such as the one in #93670 users get at least some friendly error instead of a plain crash with no further info.