Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphEdit] Add a note about the behavior of get_children() #93732

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

Geometror
Copy link
Member

Stopgap measure for #91857.

Possible long term solutions could be:

  • Add a get_graph_elements() method which only returns the graph elements
  • Add a get_connection_layer_index() method to retrieve the index of the connection layer (to filter it out manually)
  • Implement internal nodes at arbitrary positions

@Geometror Geometror force-pushed the ge-get-children-docs branch from c34bd87 to 29a6f17 Compare June 29, 2024 10:22
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@akien-mga akien-mga changed the title [GraphEdit] Add a note about the behavior of get_children() [GraphEdit] Add a note about the behavior of get_children() Jun 29, 2024
@Geometror Geometror force-pushed the ge-get-children-docs branch from 29a6f17 to 7af7933 Compare June 29, 2024 11:30
@akien-mga
Copy link
Member

Needs a rebase to fix CI.

@Geometror Geometror force-pushed the ge-get-children-docs branch from 7af7933 to 3d34a25 Compare June 29, 2024 17:40
@akien-mga akien-mga merged commit 451ed23 into godotengine:master Jun 29, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants