[Web] Remove unnecessary EMCC_FORCE_STDLIBS in dlink builds
#93853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jul 2, 2024
akien-mga
changed the title
EMCC_FORCE_STDLIBS in dlink builds
As discussed with upstream, the C/C++ standard library is always fully included when building with MAIN_MODULE=1, so using EMCC_FORCE_STDLIBS is not necessary in our case.
Faless
force-pushed
the
web/no_force_stdlib
branch
from
cec9171 to
67c0686
Compare
akien-mga
approved these changes
Jul 2, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with upstream, the C/C++ standard library is always fully included when building with
MAIN_MODULE=1(not subject to DCE), so usingEMCC_FORCE_STDLIBSis not necessary in our case.This also, incidentally, fixes non-threaded dlink builds without having to wait for emscripten-core/emscripten#22171 to be released.