Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that the Mesh.ARRAY_NORMAL array will normalize its contents internally #93872

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Clarify that the Mesh.ARRAY_NORMAL array will normalize its contents internally #93872

merged 1 commit into from
Jul 4, 2024

Conversation

MikeXYZW
Copy link
Contributor

@MikeXYZW MikeXYZW commented Jul 2, 2024 •
edited by akien-mga
Loading

Added a note to the ARRAY_NORMAL's description in accordance with issue #93693 .
Please double-check my phrasing. Thanks in advance.

Bugsquad edit:

@MikeXYZW MikeXYZW requested a review from a team as a code owner July 2, 2024 18:45
@AThousandShips AThousandShips added this to the 4.x milestone Jul 3, 2024
@AThousandShips AThousandShips added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jul 3, 2024
@AThousandShips
Copy link
Member

Please update the PR title to reflect what is actually done

@MikeXYZW MikeXYZW changed the title Updated doc/classes/Mesh.xml Clarify that the Mesh.ARRAY_NORMAL array will normalize its contents internally if the submitted vectors are not normalized beforehand Jul 3, 2024
@MikeXYZW
Copy link
Contributor Author

MikeXYZW commented Jul 3, 2024

Sure thing

@clayjohn clayjohn modified the milestones: 4.x, 4.3 Jul 3, 2024
@clayjohn clayjohn removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Jul 3, 2024
@akien-mga akien-mga changed the title Clarify that the Mesh.ARRAY_NORMAL array will normalize its contents internally if the submitted vectors are not normalized beforehand Clarify that the Mesh.ARRAY_NORMAL array will normalize its contents internally Jul 4, 2024
@akien-mga akien-mga merged commit 0c6aa7a into godotengine:master Jul 4, 2024
17 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga akien-mga mentioned this pull request Jul 4, 2024
Closed
@MikeXYZW
Copy link
Contributor Author

MikeXYZW commented Jul 4, 2024

Yay! Thank you :)

@MikeXYZW MikeXYZW deleted the patch-1 branch July 4, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Normal values gets changed even when using skip_vertex_transform render_mode
4 participants
@MikeXYZW @AThousandShips @akien-mga @clayjohn