Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some VisualShader features for high DPI displays/custom UI scales #93903

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

Geometror
Copy link
Member

@Geometror Geometror commented Jul 3, 2024

Changes:

  • Fixes GraphFrame autoshrink not taking titlebar height into account and adjusts the VisualShader theme.
  • Fixes the reroute node dimensions

A new unexposed getter getter for the titlebar height is added. (As get_titlebar_hbox is not const)

Before (200% editor scale):

grafik

After (200% editor scale);

grafik

@Geometror Geometror added this to the 4.3 milestone Jul 3, 2024
@Geometror Geometror requested review from a team as code owners July 3, 2024 16:34
@adamscott
Copy link
Member

adamscott commented Jul 3, 2024

Works A1 on my Macbook Pro.

Capture d’écran, le 2024-07-03 à 13 30 17

@Geometror Geometror force-pushed the vs-fix-frame-edscale branch from 2c0c5fc to b871794 Compare July 4, 2024 17:21
@Geometror Geometror requested a review from a team as a code owner July 4, 2024 17:21
@Geometror Geometror changed the title Fix GraphFrame autoshrink with high DPI displays/custom UI scales Fix some VisualShader features for high DPI displays/custom UI scales Jul 4, 2024
@Geometror
Copy link
Member Author

Small update: Now the reroute node looks identical regardless of the UI scale and uses AA.

@akien-mga akien-mga merged commit 5c84398 into godotengine:master Jul 4, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants