Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Control nodes emitting unnecessary resized signals #93908

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

Geometror
Copy link
Member

@Geometror Geometror commented Jul 3, 2024

Fix Control nodes emitting unnecessary resized signals due to floating point precision issues.

Fixes #93832
Might fix #48935 (for 4.3).

@Naros
Copy link
Contributor

Naros commented Jul 3, 2024

Hi @Geometror, tested but it behaves strangely in the GraphEdit:
image

I don't see the excessive resize events, but the curves don't redraw when moving a GraphNode on the canvas.
As soon as I resize the GraphNode, the curves redraw.

@Geometror Geometror force-pushed the ge-resized-fix branch 2 times, most recently from b4f5ae3 to 08bee12 Compare July 4, 2024 16:36
@Geometror
Copy link
Member Author

@Naros Should work now, I just missed a code path while restructuring the method.

Copy link
Contributor

@Naros Naros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, I don't notice any unnecessary resize events and the GraphEdit works when panning, moving nodes, scrolling the canvas both with/without snapping. 👍 Will this be backported to 4.2 as well?

scene/gui/control.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga requested a review from KoBeWi July 4, 2024 20:05
@akien-mga akien-mga merged commit b97110c into godotengine:master Jul 5, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphNode raises excessive resized events Tweening a rect_position changes rect_size
5 participants