-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Control
nodes emitting unnecessary resized
signals
#93908
Conversation
Hi @Geometror, tested but it behaves strangely in the I don't see the excessive resize events, but the curves don't redraw when moving a |
b4f5ae3
to
08bee12
Compare
@Naros Should work now, I just missed a code path while restructuring the method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, I don't notice any unnecessary resize events and the GraphEdit works when panning, moving nodes, scrolling the canvas both with/without snapping. 👍 Will this be backported to 4.2 as well?
Thanks! |
Fix
Control
nodes emitting unnecessaryresized
signals due to floating point precision issues.Fixes #93832
Might fix #48935 (for 4.3).