ResourceLoader: Fixup management of thread-specific status
#93928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows the message queue override to flush after loading each resource, which was the original intent. - Removes a redundant call to mark the thread as safe-for-nodes.
RandomShaper
force-pushed
the
fix_res_load_flush
branch
from
b561e22 to
f952d39
Compare
akien-mga
approved these changes
Jul 8, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: The effect of this is that external resources that could be successfully loaded have their deferred setup calls run regardless the load will be reported as failed. This is important because if another simultaneous load will get them from cache while they still exist, they will be guaranteedly "complete." Moreover, such behavior was also the case before those calls were flushed in loader threads. Formerly, they were flushed on the main thread so if some resource would survive an overall failed load, they'd still get that "completeness" guarantee.