Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vertex color import to handle Blender 4.2 upwards #93998

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Update vertex color import to handle Blender 4.2 upwards #93998

merged 1 commit into from
Jul 7, 2024

Conversation

demolke
Copy link
Contributor

@demolke demolke commented Jul 6, 2024 •
edited by akien-mga
Loading

Blender commit https://projects.blender.org/blender/blender/commit/0f0a8df8a922cdb0796c0b3fdbdc5c669efb3059 which is landing in 4.2 deprecated vertex_colors GLTF property, use export_vertex_color instead.

Fixes: #93997
Fixes: #92365

@demolke demolke requested a review from a team as a code owner July 6, 2024 12:16
@demolke demolke changed the title Update vertex color export to handle Blender 4.2 upwards Update vertex color import to handle Blender 4.2 upwards Jul 6, 2024
@demolke
Update vertex color import to handle Blender 4.2 upwards
7864abb 
Blender commit https://projects.blender.org/blender/blender/commit/0f0a8df8a922cdb0796c0b3fdbdc5c669efb3059 which is landing in 4.2 deprecated `vertex_colors` GLTF property, use `export_vertex_color` instead.
@AThousandShips AThousandShips added this to the 4.x milestone Jul 6, 2024
@akien-mga akien-mga added bug and removed enhancement labels Jul 7, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jul 7, 2024
@akien-mga akien-mga added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 7, 2024
@akien-mga akien-mga merged commit 080b975 into godotengine:master Jul 7, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@demolke demolke deleted the blender42 branch July 7, 2024 15:16
@IRLadderGoat IRLadderGoat mentioned this pull request Aug 3, 2024
Closed
@akien-mga akien-mga mentioned this pull request Aug 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:import topic:3d
Projects
None yet
Milestone
4.3
3 participants
@demolke @akien-mga @AThousandShips