Fix RichTextLabel + ui_down scrolling too far
#94003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
KoBeWi
approved these changes
Jul 10, 2024
akien-mga
changed the title
ui_down scrolling too far
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Using the down key (ui_down) made rich text labels such as the in-editor documentation scroll way too far down.
The scroll amount effectively doubled every time.
I did not find an open issue for this, but this is an easy fix.
Godot-Versions:
Bug introduced in #90988 / 30356a4
First release with the bug: 4.3-dev6
Cause of issue:
A recent commit replaced an absolute scroll values with relative ones, but in the case of ui_down did not remove the now superfluous current value.
How to check this PR:
Use the down key / ui_down (not the mouse wheel) in the in-editor documentation. Without this PR the scroll amount doubles, i.e. jumping from the middle to the end.
With this PR the documentation scrolls as expected.