Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UTF-8 misinterpreted as Latin-1 when logging to file #94006

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

alvinhochun
Copy link
Contributor

Fixes #93882
Regression from #90900

@alvinhochun alvinhochun requested a review from a team as a code owner July 6, 2024 18:48
@AThousandShips AThousandShips added this to the 4.3 milestone Jul 6, 2024
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit 438382c into godotengine:master Jul 7, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@alvinhochun alvinhochun deleted the log-file-utf8-fix branch July 7, 2024 13:35
@akien-mga akien-mga changed the title Fix UTF-8 misintepreted as Latin-1 when logging to file Fix UTF-8 misinterpreted as Latin-1 when logging to file Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log chinese error.
3 participants