Fix Web samples finished missing signal #94044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
force-pushed
the
fix-web-sample-playback-finished-signal
branch
from
42d646a to
21d7dc4
Compare
akien-mga
reviewed
Jul 7, 2024
adamscott
force-pushed
the
fix-web-sample-playback-finished-signal
branch
from
21d7dc4 to
a38f30f
Compare
|
@akien-mga I fixed the elements you underlined in your review! |
akien-mga
approved these changes
Jul 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93904
(not working yet, but soon)Edit: works like a charm.