Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message being printed when importing an OBJ with no surfaces #94102

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 8, 2024

An OBJ with no surfaces is valid, and typically happens when you import an OBJ mesh with no associated MTL file.

Previously, this was printed every time you imported such an OBJ:

ERROR: Index p_surface = -1 is out of bounds (surfaces.size() = 0).
   at: set_surface_name (./scene/resources/3d/importer_mesh.cpp:216)

Testing project: test_obj_import_no_surfaces.zip

An OBJ with no surfaces is valid, and typically happens when
you import an OBJ mesh with no associated MTL file.
@Calinou Calinou requested a review from a team as a code owner July 8, 2024 21:15
@Calinou Calinou added bug topic:import topic:3d cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jul 8, 2024
@Calinou Calinou added this to the 4.3 milestone Jul 8, 2024
@akien-mga akien-mga merged commit 6d2fe76 into godotengine:master Jul 8, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the obj-import-fix-no-surfaces-error branch July 9, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:import topic:3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants