Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS/Text Input] Avoid deleting and reentering unchanged part of text. #94114

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jul 9, 2024

Prevents excessive deleting and reentering text during virtual keyboard input on iOS.

Fixes #92703

Not a perfect solution, but should prevent completely meaningless text_changed events. For 4.4 virtual keyboard code probably should be redone and unified with IME to avoid sending synthesized keystrokes at all, and bidirectionally sync text and selection directly.

@bruvzg bruvzg added this to the 4.3 milestone Jul 9, 2024
@bruvzg bruvzg requested a review from a team as a code owner July 9, 2024 05:36
@akien-mga akien-mga merged commit 1b0430d into godotengine:master Jul 9, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text_changed signal for LineEdit Node is improperly emitted multiple times on mobile (iOS)
2 participants