Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up RenderDataExtension's descriptions #94217

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

DevPoodle
Copy link
Contributor

This PR does 3 things:
First, the description of "_get_render_scene_buffers" was clearly meant to be for "_get_environment", so I moved that description to the right spot.
Second, I added a new description for "_get_render_scene_buffers" based on the descriptions of the other methods.
Third, I added apostrophes to all instances of "implementations".
Hope this helps!

@DevPoodle DevPoodle requested a review from a team as a code owner July 11, 2024 15:07
@AThousandShips AThousandShips added this to the 4.x milestone Jul 11, 2024
@AThousandShips AThousandShips requested a review from a team July 11, 2024 15:11
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right.

@clayjohn clayjohn modified the milestones: 4.x, 4.3 Jul 11, 2024
@akien-mga akien-mga merged commit af33276 into godotengine:master Jul 11, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@DevPoodle DevPoodle deleted the rd-docs branch July 11, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants