Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embree: Fix include order causing unwanted dllexport symbols #94256

Merged

Conversation

alvinhochun
Copy link
Contributor

Fixes #94178

(Created upstream PR RenderKit/embree#494)

@alvinhochun alvinhochun requested a review from a team as a code owner July 12, 2024 10:01
@AThousandShips AThousandShips added this to the 4.3 milestone Jul 12, 2024
@AThousandShips AThousandShips requested a review from a team July 12, 2024 10:07
@alvinhochun
Copy link
Contributor Author

This is now included upstream in Embree v4.3.3

@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jul 31, 2024
@akien-mga akien-mga merged commit 3c7eb6a into godotengine:master Jul 31, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@alvinhochun alvinhochun deleted the embree-include-order-dllexport-fix branch August 28, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:thirdparty
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwanted DLL export functions from embree::TaskScheduler
3 participants