Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocompletion: Make argument option completion possible on script types #94259

Closed
wants to merge 1 commit into from
Closed

Autocompletion: Make argument option completion possible on script types #94259

wants to merge 1 commit into from

Conversation

HolonProduction
Copy link
Member

@HolonProduction HolonProduction commented Jul 12, 2024 •
edited
Loading

Fixes #92878

Argument _find_argument_options didn't handle SCRIPT types (it still doesn't fully, but this is mainly to fix the regression without high risk changes). Before #79386 we just used Node as type for every get node literal so we never hit that problem.

@HolonProduction HolonProduction requested a review from a team as a code owner July 12, 2024 11:08
@AThousandShips AThousandShips added this to the 4.4 milestone Jul 12, 2024
@AThousandShips AThousandShips added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jul 12, 2024
@HolonProduction
Copy link
Member Author

Just noticed that I also have #85382 which added the argument hint support for this case, but did not properly iterate over the base types, so I added this changes to the other PR to end up with something fully working.

Closing in favor of #85382

@HolonProduction HolonProduction mentioned this pull request Jul 13, 2024
Merged
@AThousandShips AThousandShips added archived and removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jul 13, 2024
@AThousandShips AThousandShips removed this from the 4.4 milestone Jul 13, 2024
@HolonProduction HolonProduction deleted the a-better-type-can-be-worse branch October 5, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived bug regression topic:editor topic:gdscript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Godot code completion not showing available signal when calling connect() on node reference
2 participants
@HolonProduction @AThousandShips