Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resources being skipped in InstancePlaceholder #94345

Conversation

matheusmdx
Copy link
Contributor

Fix #94266

image


I also tested with mrp from #88662 (comment) and seems to be working as expected

image

@matheusmdx matheusmdx requested a review from a team as a code owner July 14, 2024 11:49
@AThousandShips AThousandShips added this to the 4.3 milestone Jul 14, 2024
@matheusmdx matheusmdx force-pushed the fix-instance-placeholder-with-resource branch from 5c7e81a to 75c4df0 Compare July 14, 2024 13:48
@matheusmdx matheusmdx force-pushed the fix-instance-placeholder-with-resource branch from 75c4df0 to 2f0beee Compare July 17, 2024 12:46
@matheusmdx matheusmdx force-pushed the fix-instance-placeholder-with-resource branch from 2f0beee to 260c051 Compare July 17, 2024 13:25
@akien-mga akien-mga merged commit e7b6245 into godotengine:master Jul 17, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@matheusmdx matheusmdx deleted the fix-instance-placeholder-with-resource branch July 17, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InstancePlaceholder doesn't assign Resource to instance
3 participants