[Core] Fix TypedArray encoding when full objects is disabled #94379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalexeev
reviewed
Jul 15, 2024
dalexeev
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Makes sense to me, thanks! Note that this creates some inconsistency: with p_full_objects = false pathless scripts are supported, but with p_full_objects = true they are not. However, it's less controversial than #90990, so we can fix it in the future if necessary.
Faless
force-pushed
the
fix/debugger_typed_array
branch
from
c28b51d
to
3145442
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typed arrays containing objects, are now correctly encoded with type
EncodedObjectAsIDwhen full objects is disabled.Alternative to #90990
Fixes #90467
Fixes #94384