Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when exporting files without import parameters #94405

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix error when exporting files without import parameters #94405

merged 1 commit into from
Jul 17, 2024

Conversation

ydeltastar
Copy link
Contributor

Calinou
Calinou reviewed Jul 15, 2024
View reviewed changes
editor/export/editor_export_platform.cpp Outdated
@@ -1230,7 +1230,9 @@ Error EditorExportPlatform::export_project_files(const Ref<EditorExportPreset> &

// Erase useless sections.
config->erase_section("deps");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also have a check just in case?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "deps" always has elements in it since it stores the path of the source file and the imported file. So we shouldn't need to check it

Calinou
Calinou reviewed Jul 15, 2024
View reviewed changes
editor/export/editor_export_platform.cpp Outdated
@@ -1295,7 +1297,9 @@ Error EditorExportPlatform::export_project_files(const Ref<EditorExportPreset> &

// Erase useless sections.
config->erase_section("deps");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@Calinou Calinou added this to the 4.3 milestone Jul 15, 2024
clayjohn
clayjohn approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

It seems like the [params] section is ignored when the config is loaded because it never contains any items.

Additionally, the only other place that config->erase_section("params"); is called, checks for the existence of "params" first

@akien-mga akien-mga merged commit cb2650c into godotengine:master Jul 17, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@ydeltastar ydeltastar deleted the fix-export-no-params branch July 17, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou left review comments

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:export
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Compute shader file gives error when exporting project
4 participants
@ydeltastar @akien-mga @Calinou @clayjohn