Fix ScriptEditor scrolling horizontally when reopening script #94439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
approved these changes
Jul 23, 2024
|
Thanks! |
|
This doesn't fix #33865 in all situations, such as when the editor is opened. It may depend on resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script must have enough text to be able to scroll horizontally and the caret must not be saved on column 0.
The editor was scrolling horizontally to put the caret at the left edge of the screen when it doesn't need to.
There is another issue that causes it to scroll horizontally when the Editor opens, this only fixes it when a script is reopened.
adjust_viewport_to_caretwas being called before the TextEdit is resized initially, so thevisible_widthwas invalid.Bugsquad Edit: Fixes #33865