Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unique name in scene when making a node the root node #94491

Merged

Conversation

iiMidknightii
Copy link
Contributor

Fixes #94487. Now when setting a node as the root, it should strip the unique name access. Undo should restore the previous state.

@iiMidknightii iiMidknightii requested a review from a team as a code owner July 18, 2024 02:55
@akien-mga akien-mga added this to the 4.3 milestone Jul 18, 2024
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jul 18, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@akien-mga akien-mga changed the title Fix For Unique Node Names Moved To Root Disable unique name in scene when making a node the root node Jul 18, 2024
@akien-mga akien-mga merged commit 5ae8ac5 into godotengine:master Jul 18, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Revoke Unique Name on Scene Root Node
2 participants