Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat MenuBar and MenuButton as advanced UI #94513

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Jul 18, 2024

These rely entirely on other advanced UI elements, namely popup menu

Follow-up to:

@AThousandShips AThousandShips added this to the 4.x milestone Jul 18, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner July 18, 2024 14:22
@RedMser
Copy link
Contributor

RedMser commented Jul 18, 2024

As a follow-up PR, this docs page should also be updated: https://docs.godotengine.org/en/stable/contributing/development/compiling/optimizing_for_size.html#disabling-advanced-gui-objects

@AThousandShips
Copy link
Member Author

I've been planning to improve some of the descriptions there as they're already somewhat out of sync, will do as well

@AThousandShips
Copy link
Member Author

Opened a doc PR to handle the new entries as well as improve some of the style there:

@akien-mga akien-mga merged commit d1c238f into godotengine:master Aug 28, 2024
18 checks passed
@AThousandShips AThousandShips deleted the no_adv_gui_improve branch August 28, 2024 14:43
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants