Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End benchmark of Main::setup properly before calling setup2 #94587

Merged
merged 1 commit into from
Jul 22, 2024
Merged

End benchmark of Main::setup properly before calling setup2 #94587

merged 1 commit into from
Jul 22, 2024

Conversation

alvinhochun
Copy link
Contributor

No description provided.

@alvinhochun alvinhochun requested a review from a team as a code owner July 21, 2024 13:46
@AThousandShips AThousandShips added this to the 4.x milestone Jul 21, 2024
@alvinhochun
Copy link
Contributor Author

This is a very straightforward bugfix that should be included in 4.3.

@AThousandShips
Copy link
Member

AThousandShips commented Jul 21, 2024 •
edited
Loading

Please open a bug report for this or where was this being a bug discussed? I'm not sure this is a bug, what makes startup2 not part of Main::Setup? This would change the benchmark data drastically

Edit: Noticed there was a separate Main::Setup2, so this is correct, in the future please elaborate on the reason for a bug fix if there isn't an associated report to make it easier to indicate what actually is wrong or why it should be changed

@AThousandShips AThousandShips modified the milestones: 4.x, 4.3 Jul 21, 2024
@akien-mga akien-mga changed the title End benchmark of Main::Setup properly before calling setup2 End benchmark of Main::setup properly before calling setup2 Jul 21, 2024
akien-mga
akien-mga approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, setup2 has its own benchmark.

@akien-mga akien-mga merged commit edcf789 into godotengine:master Jul 22, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@alvinhochun alvinhochun deleted the bench-end-main-setup branch July 29, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@alvinhochun @AThousandShips @akien-mga