Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Editor: Disable file reimport when .import changes #94691

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Jul 24, 2024

This is disabling (for Android only) the logic added in #84974 which caused #94416. That issue still needs to be debugged further, but this works around the regression and should have minimal usability impact on Android.

This is disabling the logic added in godotengine#84974 which caused godotengine#94416.
That issue still needs to be debugged further, but this works around
the regression and should have minimal usability impact on Android.
@Saul2022
Copy link

Can confirm this works great now though when clicking on delete files for the first time after opening the project there's a bit of stutter, but that just the first time, it fine to close the issue in my opinion as it is fixed and then search for how to properly fix that bug.

@bsil78
Copy link

bsil78 commented Jul 24, 2024

Hello @akien-mga, FYI, this commit makes my project crash on Windows 10 with :

================================================================
CrashHandlerException: Program crashed
Engine version: Godot Engine v4.3.beta.gh-94691 (f53ed52592b0ded7ee0129f17801636951a99bea)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[0] <couldn't map PC to fn name>
[1] <couldn't map PC to fn name>
[2] <couldn't map PC to fn name>
[3] <couldn't map PC to fn name>
[4] <couldn't map PC to fn name>
[5] <couldn't map PC to fn name>
[6] <couldn't map PC to fn name>
[7] <couldn't map PC to fn name>
[8] <couldn't map PC to fn name>
[9] <couldn't map PC to fn name>
[10] <couldn't map PC to fn name>
[11] <couldn't map PC to fn name>
[12] <couldn't map PC to fn name>
[13] <couldn't map PC to fn name>
[14] <couldn't map PC to fn name>
[15] <couldn't map PC to fn name>
[16] <couldn't map PC to fn name>
[17] <couldn't map PC to fn name>
[18] <couldn't map PC to fn name>
[19] <couldn't map PC to fn name>
[20] <couldn't map PC to fn name>
[21] <couldn't map PC to fn name>
[22] <couldn't map PC to fn name>
[23] <couldn't map PC to fn name>
[24] <couldn't map PC to fn name>
[25] <couldn't map PC to fn name>
[26] <couldn't map PC to fn name>
[27] <couldn't map PC to fn name>
[28] <couldn't map PC to fn name>
[29] <couldn't map PC to fn name>
[30] <couldn't map PC to fn name>
[31] <couldn't map PC to fn name>
[32] <couldn't map PC to fn name>
[33] <couldn't map PC to fn name>
[34] <couldn't map PC to fn name>
[35] <couldn't map PC to fn name>
[36] <couldn't map PC to fn name>
[37] <couldn't map PC to fn name>
[38] <couldn't map PC to fn name>
[39] <couldn't map PC to fn name>
[40] <couldn't map PC to fn name>
[41] <couldn't map PC to fn name>
[42] <couldn't map PC to fn name>
[43] <couldn't map PC to fn name>
[44] <couldn't map PC to fn name>
[45] <couldn't map PC to fn name>
[46] <couldn't map PC to fn name>
[47] <couldn't map PC to fn name>
[48] <couldn't map PC to fn name>
[49] <couldn't map PC to fn name>
[50] <couldn't map PC to fn name>
[51] <couldn't map PC to fn name>
[52] <couldn't map PC to fn name>
[53] <couldn't map PC to fn name>
[54] <couldn't map PC to fn name>
[55] <couldn't map PC to fn name>
[56] <couldn't map PC to fn name>
[57] <couldn't map PC to fn name>
[58] <couldn't map PC to fn name>
[59] <couldn't map PC to fn name>
[60] <couldn't map PC to fn name>
[61] <couldn't map PC to fn name>
[62] <couldn't map PC to fn name>
[63] <couldn't map PC to fn name>
[64] <couldn't map PC to fn name>
[65] <couldn't map PC to fn name>
[66] <couldn't map PC to fn name>
[67] <couldn't map PC to fn name>
[68] <couldn't map PC to fn name>
[69] <couldn't map PC to fn name>
[70] <couldn't map PC to fn name>
-- END OF BACKTRACE --
================================================================

@akien-mga
Copy link
Member Author

@bsil78 That's not possible, it must be a different commit (merged today too maybe?).

This commit doesn't change anything for how Windows builds are made, it only impacts Android builds.

@bsil78
Copy link

bsil78 commented Jul 24, 2024

I tested it 2 times ; it is this one. How ? I don't know. I seems impossible you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants