-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Editor: Disable file reimport when .import changes #94691
Android Editor: Disable file reimport when .import changes #94691
Conversation
This is disabling the logic added in godotengine#84974 which caused godotengine#94416. That issue still needs to be debugged further, but this works around the regression and should have minimal usability impact on Android.
Can confirm this works great now though when clicking on delete files for the first time after opening the project there's a bit of stutter, but that just the first time, it fine to close the issue in my opinion as it is fixed and then search for how to properly fix that bug. |
Hello @akien-mga, FYI, this commit makes my project crash on Windows 10 with :
|
@bsil78 That's not possible, it must be a different commit (merged today too maybe?). This commit doesn't change anything for how Windows builds are made, it only impacts Android builds. |
I tested it 2 times ; it is this one. How ? I don't know. I seems impossible you are right. |
This is disabling (for Android only) the logic added in #84974 which caused #94416. That issue still needs to be debugged further, but this works around the regression and should have minimal usability impact on Android.