Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript: Fix locals clearing after exiting while block #94730

Merged
merged 1 commit into from
Jul 26, 2024
Merged

GDScript: Fix locals clearing after exiting while block #94730

merged 1 commit into from
Jul 26, 2024

Conversation

dalexeev
Copy link
Member

This PR unifies the use of the following functions:

  • start_block();
  • _add_block_locals();
  • _parse_block();
  • _clear_block_locals();
  • end_block().

@dalexeev dalexeev added this to the 4.3 milestone Jul 25, 2024
@dalexeev dalexeev requested a review from a team as a code owner July 25, 2024 09:13
vnen
vnen approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@vnen vnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit b2facc0 into godotengine:master Jul 26, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the gds-fix-while-locals-clearing branch July 26, 2024 15:17
@Snowlette Snowlette mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnen vnen vnen approved these changes

Assignees
No one assigned
Labels
bug regression topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

GDScript regression: Compiler bug: unresolved assign
3 participants
@dalexeev @akien-mga @vnen