-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pink GradientTexture2D #94744
Fix pink GradientTexture2D #94744
Conversation
I think that EDIT: |
see my suggested fix: #93759 (comment) |
I tried to apply this changes but i'm getting an error when i compile, most probably i'm doing something wrong: Sorry if is some silly error, i'm don't have much knowledge of c++ |
ive made the same changes and didn't get any compiler error |
e294f4c
to
7a0cd87
Compare
@rune-scape I pushed my changes for this pr can you check the tests results? |
whoa, i swear i thought i compiled it, but ya im getting the same cryptic errors |
made a PR (#94864) that fixes that problem and tested that these changes compile with that change |
@@ -172,14 +172,13 @@ RID GradientTexture1D::get_rid() const { | |||
} | |||
|
|||
Ref<Image> GradientTexture1D::get_image() const { | |||
const_cast<GradientTexture1D *>(this)->update_now(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this and the other call to update_now()
should still be here, just as a regular method call without the const_cast
510d6f3
to
cd2c37e
Compare
Changes done, i also updated the pr description to inform about #94864 |
Can be rebased as #94864 was just merged. |
cd2c37e
to
3e0d3c4
Compare
Done |
Note for release management: To cherry-pick this to 4.3, #94864 would need to be cherry-picked first. |
Thanks! |
Fix #93759, needs #94864 first.
This pr apply the suggested changes here: #93759 (comment)