-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for places to receive InputEventShortcut #94745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
enhancement
documentation
cherrypick:4.1
Considered for cherry-picking into a future 4.1.x release
cherrypick:4.2
Considered for cherry-picking into a future 4.2.x release
cherrypick:4.3
Considered for cherry-picking into a future 4.3.x release
labels
Jul 25, 2024
Sauermann
reviewed
Jul 25, 2024
anniryynanen
force-pushed
the
shortcut-input-too
branch
from
July 26, 2024 06:09
92eeef0
to
f97e81b
Compare
anniryynanen
force-pushed
the
shortcut-input-too
branch
from
July 26, 2024 08:53
f97e81b
to
1e79d11
Compare
Commit and title could say something different. They read as if this is a bug being reported, instead of a documentation fix. |
anniryynanen
force-pushed
the
shortcut-input-too
branch
from
July 26, 2024 13:56
1e79d11
to
a56391b
Compare
anniryynanen
changed the title
InputEventShortcut can also be received in _shortcut_input
Update documentation for places to receive InputEventShortcut
Jul 26, 2024
Sauermann
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes fix the previously outdated statement.
akien-mga
removed
the
cherrypick:4.3
Considered for cherry-picking into a future 4.3.x release
label
Jul 26, 2024
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
cherrypick:4.1
Considered for cherry-picking into a future 4.1.x release
cherrypick:4.2
Considered for cherry-picking into a future 4.2.x release
documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't test it myself, but https://docs.godotengine.org/en/latest/tutorials/inputs/inputevent.html#how-does-it-work and https://docs.godotengine.org/en/latest/classes/class_node.html#class-node-private-method-shortcut-input say so.