Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for places to receive InputEventShortcut #94745

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

@anniryynanen anniryynanen requested a review from a team as a code owner July 25, 2024 17:36
@AThousandShips AThousandShips added enhancement documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jul 25, 2024
@AThousandShips AThousandShips requested a review from a team July 25, 2024 17:37
@AThousandShips AThousandShips added this to the 4.x milestone Jul 25, 2024
@Sauermann Sauermann added bug and removed enhancement labels Jul 25, 2024
@Sauermann Sauermann modified the milestones: 4.x, 4.4 Jul 25, 2024
@Mickeon
Copy link
Contributor

Mickeon commented Jul 26, 2024

Commit and title could say something different. They read as if this is a bug being reported, instead of a documentation fix.

@anniryynanen anniryynanen changed the title InputEventShortcut can also be received in _shortcut_input Update documentation for places to receive InputEventShortcut Jul 26, 2024
Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes fix the previously outdated statement.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Jul 26, 2024
@akien-mga akien-mga modified the milestones: 4.4, 4.3 Jul 26, 2024
@akien-mga akien-mga merged commit 1322fd3 into godotengine:master Jul 28, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants