Determine break_loop_at_end 1 frame earlier using prediction by delta
#94858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
early-break-loop-at-end
branch
from
b73531c to
4de79fe
Compare
akien-mga
approved these changes
Jul 28, 2024
akien-mga
changed the title
break_loop_at_end 1 frame earlier using prediction by delta
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnimationNodeStateMachineTransition.break_loop_at_endis unreliable #94767Make the break_loop_at_end decision one frame earlier.
Currently, break_loop_at_end returned remain 0 "after looped", using the is_just_looped flag, resulting in a slight delay, causing problems such as unintended processing of the first frame.
Instead of the is_just_looped flag, the will_end flag should be managed by a delta-based prediction. Using that, only if a loop is set up, the end frame of the animation (since it would be identical to the first frame as described in #94768 (comment)) would be exited without processing.
Also fixed lack of consideration of delta when searching for transitions.