Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't drop PackedScene as property #95090

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Aug 3, 2024

Closes #94959

This PR reverts the behavior change introduced in #92004.

Treating PackedScene the same as other resources is technically more consistent. But it's counterintuitive from the perspective of UX (Users typically do not consider scene files as a type of resource).

I did not bother adding an editor setting for toggling between the behaviors since it's the safe-old behavior of dropping PackedScene and we're in the RC stage. I don't want to introduce more moving parts :P

@timothyqiu timothyqiu added this to the 4.3 milestone Aug 3, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner August 3, 2024 06:58
@akien-mga akien-mga merged commit ee986b7 into godotengine:master Aug 6, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the scene-drop branch August 6, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a new scene from FileSystem dock can misfire if a Scene has an @export … PackedScene
3 participants