Fix shader crash when the comma used in for loop as a trailing

[Chaosus]

Prevents shader compiler crash (not an actual crash) when using incorrect trailing commas in for loop expression:

for(int i = 0; i < 0, ; i++, )

[geekley]

Thanks @Chaosus . Is this only for dealing with trailing commas (to show text editor error instead of crash)?

for (int i = 0, j = 0; i < 9 && j < 9; i++, j++)
Is comma on 3rd (continuation) part still valid?

for (int i = 0, j = 0; (i = f(i)), i < 9; i++, j++)
Is comma on 2nd (condition) part now made invalid or does it have comma operator semantics (fixing to allow non-bool before the comma)? Should I still open an issue for this one? Done at #95451

[Chaosus]

Is comma on 3rd (continuation) part still valid?

Yes

for (int i = 0, j = 0; (i = f(i)), i < 9; i++, j++)

This is not a valid because only boolean expressions are allowed on middle place. That is allowed expression in GLSL, though.

[geekley]

This is not a valid because only boolean expressions are allowed on middle place. That is allowed expression in GLSL, though.

Exactly. It's valid GLSL because only the last comma part needs to be a boolean (if you allow commas here like in GLSL).
If all parts are required to be a boolean, it makes it seem as if the comma means something else, like e.g. an AND or OR operator (which do get passed a boolean). Comma operator doesn't need compatible types between its parts.

[Calinou]

Tested locally, it works as expected.

In master, I get a core shader compilation error and the editor freezes instead.

[akien-mga]

Thanks!

[akien-mga]

Cherry-picked for 4.3.1.