Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ShapeCast{2D,3D}::get_collision_result #95374

Conversation

raulsntos
Copy link
Member

This allows language bindings like godot-cpp to access the read-only property collision_result. Although it's possible this property was meant to be internal. If so, we can just add the PROPERTY_USAGE_INTERNAL flag to the property instead.

Copy link
Member

@rburing rburing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the (read-only) property was already exposed, the getter should be too.

In fact the read-only property could be removed in favor of the getter, but in any case this is a good uncontroversial first step.

@raulsntos raulsntos force-pushed the gdextension/expose-property-accessors/ShapeCast branch from 3275117 to e47ff98 Compare August 15, 2024 14:20
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Aug 15, 2024
@akien-mga akien-mga merged commit 987635b into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the gdextension/expose-property-accessors/ShapeCast branch August 16, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants