Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Polygon2D::bones property internal #95376

Conversation

raulsntos
Copy link
Member

According to the documentation, it sounds like this property was supposed to be internal. So I'm adding the PROPERTY_USAGE_INTERNAL flag.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. I guess this technically breaks compat as this could be accessed from script before?

@KoBeWi
Copy link
Member

KoBeWi commented Aug 12, 2024

Internal properties can still be accessed in script, they just don't show in documentation and autocompletion.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Aug 16, 2024
@akien-mga akien-mga merged commit 504f81e into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the gdextension/expose-property-accessors/Polygon2D branch August 16, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants