Make Animation::capture_included read-only
#95377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `PROPERTY_USAGE_READ_ONLY` flag only makes the property read-only in the inspector, but the property also has the `PROPERTY_USAGE_NO_EDITOR` flag which means it won't show up in the inspector. So it does nothing, while still making it editable from scripting. To make it read-only for scripting too, this PR removes the setter from the `PropertyInfo`. And since the `set_capture_included` method is now unused, it was also removed.
akien-mga
approved these changes
Aug 11, 2024
|
This property is new in 4.3, so the compat breakage is only internal to 4.3 pre-relesse versions if we merge this before 4.3-stable. |
TokageItLab
approved these changes
Aug 11, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PROPERTY_USAGE_READ_ONLYflag only makes the property read-only in the inspector, but the property also has thePROPERTY_USAGE_NO_EDITORflag which means it won't show up in the inspector. So it does nothing, while still making it editable from scripting.To make it read-only for scripting too, this PR removes the setter from the
PropertyInfo. And since theset_capture_includedmethod is now unused, it was also removed.auto_captureoption to AnimationPlayer #91437.