Make OptionButton::selected
read-only
#95378
Open
+2
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
selected
property read- only, theselect
method can be used to set the value instead.The
select
method is already exposed and does the same thing as the property's setter_select_int
, which is now unused so it was removed.Alternative
Using the
select
method as the setter for theselected
property is technically possible, since both methods have the same signature, and would prevent breaking compatibility. Unfortunately, this means theselect
method becomes hidden and I'm not sure that's what we want.