-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop popup release timeout on click. #95432
Conversation
CC @mihe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected on:
Godot v4.3.rc (39fc116) - Fedora Linux 40 (KDE Plasma) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (nvidia; 555.58.02) - 13th Gen Intel(R) Core(TM) i9-13900K (32 Threads)
Single-window mode is disabled in the editor settings.
On the other hand, I can't reproduce the original issue, but at least there's no regression in behavior.
I can confirm that this fixes the issue on Windows. I'll give macOS and Linux a try as well. |
Interestingly I am/was able to reproduce this issue on both Windows and macOS, but not Linux. All platforms seemingly work fine with this PR, but I must admit I don't know what kind of regressions to look out for. |
Seems to be working fine for me, but I can't reproduce both this and previous issue without changing timeout to either extremely high or extremely small values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can reproduce the bug and confirm that this fixes it.
Thanks! |
Should fix #95430, need to be tested on all desktop platforms.