2D: Fix use-after-free in batch rendering; regression of #95574 #96977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartcarnie
force-pushed
the
96960_use_after_free
branch
from
e0f427f
to
e4f07fa
Compare
stuartcarnie
changed the title
kleonc
reviewed
Sep 13, 2024
Closes godotengine#96960 Fixes regression of godotengine#95574 using fix from godotengine#95666
stuartcarnie
force-pushed
the
96960_use_after_free
branch
from
e4f07fa
to
c113e5b
Compare
kleonc
approved these changes
Sep 13, 2024
|
I can confirm that this solves my crash! Thank you! |
akien-mga
approved these changes
Sep 14, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a use-after-free issue as
current_batchwas invalidated after_record_item_commandsifLocalVectorwas resized.Closes #96960
Resolves regression of #95574 using fix from #95666