Fix Sprite2D dialog size for smaller screen device

[shahriarlabib000]

So my editor scale was 180% by default

Before

Now

[WhalesState]

I feel like we should change window size instead of the Control's minimum size, and we leave the minimum size to be calculated automatically, to avoid such limitation.

Since if you scale the UI by 200%, you will need to make another fix to fit your screen.

[shahriarlabib000]

I have no idea how to do that. Could you pls review and suggest the change pls

[shahriarlabib000]

The easiest solution would be to set the minimum size height even lower 😅 (im joking)

[shahriarlabib000]

This went horribly

https://github.com/shahriarlabib000/godot/blob/3b60ec132b4cf9872b69b91a52fa2cebf2644894/editor/plugins/sprite_2d_editor_plugin.cpp#L601-#L602

	debug_uv->set_size(Size2(800, 400) * EDSCALE);
//	debug_uv->set_custom_minimum_size(Size2(800, 500) * EDSCALE);

[WhalesState]

Yes, it's because the Window.popup() was called without setting the window size, everything will shrink to it's minimum size, if you need some help, just search Sprite2DEditorPlugin and there's a popup call for the Window we need to set the Window size there. not in the same file, because i think it's using the WindowWrapper class.

[shahriarlabib000]

This one?

godot/editor/plugins/sprite_2d_editor_plugin.cpp

Line 157 in 2be730a

debug_uv_dialog->popup_centered();

Tried something like this before. Didn't quite work. Maybe I'll try again
shahriarlabib000@f66ad84

[WhalesState]

oh, I was searching for popup as a full word before.

Try this and see if you can freely resize the window, it should remember it's last size everytime popup is called.

If the VBoxContainer vp didn't expand we may consider using wrap_controls for the Dialog and set_anchors_and_offsets_preset(Control::PRESET_FULL_RECT) for the VBoxContainer, but I think it should expand correctly.

[shahriarlabib000]

Did that in shahriarlabib000@9b82214 right now. Works fine for most part But the popup looks too small at 100%

4.3

now

[WhalesState]

Works fine for most part But the popup looks too small at 100%

Before it was setting just the control minimum size, so the other Control nodes also provided their minimum size to be added to the Window minimum size.

Now we are setting the whole window size, so maybe we can increase the Window size a bit. 960 x 540 is fine, which will become 1920x1080 when the editor scale is x2.

[shahriarlabib000]

I think following this

If the VBoxContainer vp didn't expand we may consider using wrap_controls for the Dialog and set_anchors_and_offsets_preset(Control::PRESET_FULL_RECT) for the VBoxContainer, but I think it should expand correctly.

Also gives a similar result shahriarlabib000@41f4607

So should i just add them? Instead of changing the size?
Btw thank you very much for your help.

[WhalesState]

So should i just add them? Instead of changing the size? Btw thank you very much for your help.

No, this change is just enough for fixing the issue, since it do already expand correctly and fills the popup Window.

Btw thank you very much for your help.

You're welcome ^^

[Repiteo]

Thanks!