Add GraphEdit.cut_nodes_request signal
#97229
Open
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
GraphEdit.cut_nodes_request signal
akien-mga
reviewed
Sep 20, 2024
scene/gui/graph_edit.cpp
Outdated
| @@ -1999,6 +1999,9 @@ void GraphEdit::gui_input(const Ref<InputEvent> &p_ev) { | |||
| } else if (p_ev->is_action("ui_copy", true)) { | |||
| emit_signal(SNAME("copy_nodes_request")); | |||
| accept_event(); | |||
| } else if (p_ev->is_action("ui_cut")) { | |||
There was a problem hiding this comment.
Other actions pass true to the second parameter here, is there a reason why this one would need to differ?
There was a problem hiding this comment.
No, it seems to be a mistake on my part, will update it.
There was a problem hiding this comment.
For reference this is the check for exact match
|
Makes sense to me from a quick review, but I'll let GraphEdit / VisualShader editor experts (@Geometror or @Chaosus) evaluate further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97064
Should also close #92776