Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draw indirect to Rendering Device #97247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thimenesup
Copy link
Contributor

Self explanatory.

@thimenesup thimenesup requested a review from a team as a code owner September 20, 2024 19:06
@tetrapod00
Copy link
Contributor

I couldn't find an actual proposal for indirect rendering that this would close, but there is this discussion godotengine/godot-proposals#8647. If this works as advertised, it should satisfy multiple existing proposals that are asking for similar features but not specifically asking for "draw indirect".

@DarioSamo
Copy link
Contributor

I haven't reviewed in detail, but make sure to add the draw list usage for the indirect buffer just like how dispatch indirect does, otherwise the graph won't be able to accurately detect the dependencies. You can find the following example in the code for dispatch indirect.

if (buffer->draw_tracker != nullptr) {
    draw_graph.add_compute_list_usage(buffer->draw_tracker, RDG::RESOURCE_USAGE_INDIRECT_BUFFER_READ);
}

@clayjohn clayjohn added this to the 4.x milestone Sep 20, 2024
@thimenesup thimenesup force-pushed the draw_indirect_rd branch 2 times, most recently from 2b1a54e to 9f77260 Compare September 20, 2024 20:38
@thimenesup thimenesup requested a review from a team as a code owner September 20, 2024 20:38
@thimenesup
Copy link
Contributor Author

Fixed that, and added docs too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants