Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Add typed dictionary support for binary serialization #98120

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Core: Add typed dictionary support for binary serialization #98120

merged 1 commit into from
Nov 12, 2024

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev added this to the 4.4 milestone Oct 12, 2024
@dalexeev dalexeev requested review from a team as code owners October 12, 2024 15:28
@Repiteo Repiteo self-requested a review October 12, 2024 16:52
@dalexeev dalexeev force-pushed the core-typed-dicts-bin-serialization branch from 9ce1e26 to 0edd54b Compare October 12, 2024 18:30
@dalexeev dalexeev mentioned this pull request Oct 13, 2024
Open
Repiteo
Repiteo approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be in order!

AThousandShips
AThousandShips approved these changes Oct 18, 2024
View reviewed changes
core/io/marshalls.cpp Outdated Show resolved Hide resolved
core/io/marshalls.cpp Outdated Show resolved Hide resolved
tests/core/io/test_marshalls.h Outdated Show resolved Hide resolved
@dalexeev dalexeev force-pushed the core-typed-dicts-bin-serialization branch from 0edd54b to e861346 Compare October 18, 2024 10:02
Faless
Faless reviewed Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to test and try to do a proper re-review since it's hard to safely evaluate just by looking at the changes, but in the meantime I added a couple of readability comments

core/io/marshalls.cpp Outdated Show resolved Hide resolved
core/io/marshalls.cpp Outdated Show resolved Hide resolved
@dalexeev dalexeev force-pushed the core-typed-dicts-bin-serialization branch 2 times, most recently from f575cb7 to 22295bc Compare October 18, 2024 11:21
@dalexeev dalexeev force-pushed the core-typed-dicts-bin-serialization branch from 22295bc to 9ba098b Compare November 12, 2024 07:20
@dalexeev dalexeev requested a review from Faless November 12, 2024 08:49
Faless
Faless approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

I've gone through all changes, everything seems in order, also run some tests using the multiplayer API (which adds some custom encoding on top of the regular variant marshalling) and everything worked as expected.

Awesome work! 🥇 🏆

@Repiteo Repiteo merged commit 8fd672c into godotengine:master Nov 12, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 12, 2024

Thanks!

@dalexeev dalexeev deleted the core-typed-dicts-bin-serialization branch November 12, 2024 16:12
@dalexeev dalexeev mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@Repiteo Repiteo Repiteo approved these changes

@Faless Faless Faless approved these changes

@RandomShaper RandomShaper Awaiting requested review from RandomShaper

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@dalexeev @Repiteo @Faless @AThousandShips