[Editor]: Stop Loading .Net Project Assembly when TOOLS is not Defined
#98153
+51
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delsin-Yu
force-pushed
the
dotnet-warn-missing-tool-preprocessor
branch
from
f7c0772 to
83d121d
Compare
…ned to prevent data loss
Delsin-Yu
force-pushed
the
dotnet-warn-missing-tool-preprocessor
branch
from
83d121d to
7e74575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #78513
Closes #98124
As mentioned here, the
TOOLScompiler symbol is crucial for C# editor functionality; the absence ofTOOLScan lead to data loss and editor malfunctions (all C# script exports becomenulland Ineditable) without a proper error message.This PR ensures that the
LoadProjectAssemblyfails when theTOOLScompiler symbol does not exist and prints a useful guidance message for the user on addressing the issue.QQ20241014-5139.mp4