Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript: access level for class method and class variable #98606

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

zjin123
Copy link

@zjin123 zjin123 commented Oct 28, 2024

@dalexeev
Copy link
Member

@Lazy-Rabbit-2001
Copy link
Contributor

Lazy-Rabbit-2001 commented Oct 28, 2024

This is a superseding pr of #98136 as well, with extra stuff and access levels implemented.
Sorry but I cannot review yours, dunno why.
You have to rename your accessLevelToString() in snake_case, like access_level_to_string() to make your codes coherent in form with other parts, see DataType::to_string() and DataType::to_string_strict()

@zjin123
Copy link
Author

zjin123 commented Oct 28, 2024

This is a superseding pr of #98136 as well, with extra stuff and access levels implemented. Sorry but I cannot review yours, dunno why. You have to rename your accessLevelToString() in snake_case, like access_level_to_string() to make your codes coherent in form with other parts, see DataType::to_string() and DataType::to_string_strict()

Thanks for pointing out. I will fix the name.

@zjin123 zjin123 requested a review from a team as a code owner October 28, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants