Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim a few no-break and zero-width spaces from codebase #99031

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Trim a few no-break and zero-width spaces from codebase #99031

merged 1 commit into from
Nov 11, 2024
+2 −2

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Nov 10, 2024

These were found by accident and through trial-and-error, until I figured the catch-all RegEx [^\S \t]+.

@Mickeon Mickeon added this to the 4.4 milestone Nov 10, 2024
@Mickeon Mickeon requested review from a team as code owners November 10, 2024 18:06
Repiteo
Repiteo approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we already have systems for finding spelling errors, I imagine those same tools could detect and prune these characters too. Gonna look into that later today

@Mickeon Mickeon mentioned this pull request Nov 11, 2024
Merged
@Repiteo Repiteo merged commit a5873ff into godotengine:master Nov 11, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 11, 2024

Thanks!

@Mickeon Mickeon deleted the white-space-jumpscare branch November 11, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@Repiteo Repiteo Repiteo approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@fire fire fire approved these changes

Assignees
No one assigned
Labels
bug documentation topic:buildsystem
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Mickeon @Repiteo @fire @mhilbrunner @AThousandShips