Update gridmap editor nodes when the gridmap node transform changes #99393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver the gridmap node's transformation changes
|
CC @Nodragem |
akien-mga
reviewed
Nov 18, 2024
|
Super! That's exactly one of the thing I listed in this meta-proposal: godotengine/godot-proposals#10992 I will have a better look on Thursday if that's ok. |
Calinou
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
Testing project: test_pr_99393.zip
I noticed something else while testing: if you rotate the GridMap node, the placement preview does not rotate (but already placed meshes do):
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor fix for a gridmap editor glitch - when the gridmap node's transform changes the editor nodes for cursor and selection are now updated to reflect the new transformation.