Fix progress dialog steals focus #99844
Open
+117
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I sometimes see window focus issues when opening a project, is it possible to carry this over to importing a project? |
|
Yes, it's already included. |
KoBeWi
force-pushed
the
give_back_the_focus
branch
from
36bc47c to
3759100
Compare
KoBeWi
force-pushed
the
give_back_the_focus
branch
from
3759100 to
839ea69
Compare
Co-authored-by: Hilderin <81109165+Hilderin@users.noreply.github.com>
KoBeWi
force-pushed
the
give_back_the_focus
branch
from
839ea69 to
8d2778c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #97009, but I made the dialog appear on currently focused window. Unfortunately this can only work if the correct window is focused. I had to add some ungodly hacks to export dialog to make it work properly (and accidentally fixed #93481 🤷♂️).
godot.windows.editor.dev.x86_64_QadjiSP3oQ.mp4
Any dialog that can display editor progress potentially has this problem. If this solution is acceptable, it can be generalized into more readable solution. Alternative is adding the dialog to the top window on the window stack, but idk if such thing even exists.
Fixes #96994
Fixes #90944