Add dynamic VRS option that generates VRS density map with a shader #99916
+640
−301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Bastiaan Olij <mux213@gmail.com>
|
Still working on this but @DarioSamo @dsnopek , could love some early feedback. |
BastiaanOlij
commented
Dec 2, 2024
| PackedVector2Array eye_centers = interface->get_vrs_eye_foci(aspect_ratio); | ||
|
|
||
| // Need to vary these based on performance: | ||
| float min_radius = 0.1; |
There was a problem hiding this comment.
Note, these are hardcoded for now and the values are, uhm. not very well chosen. We'll need to experiment with values that work well and then see how we can vary them based on performance metrics.
BastiaanOlij
force-pushed
the
vrs_shader
branch
from
f1dc20a to
6b2bf84
Compare
BastiaanOlij
force-pushed
the
vrs_shader
branch
from
6b2bf84 to
9c1f5c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a VRS mode that builds the density map fully in our shader. No data needs to be calculated on the CPU and transferred to the GPU. This removes a lot of overhead and will allow us to more easily adjust the density map based on performance metrics.
Ideally we deprecate
VRS_XRin favour of this once its completed.Still todo:
Note: Build on top of #99551