Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💊 Change default value of Querybool from true to false. #2391

Merged
merged 3 commits into from
Mar 30, 2023
Merged

💊 Change default value of Querybool from true to false. #2391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5b64bd
🩹 Fix QueryBool function: change default value from true to false
dozheiny Mar 30, 2023
68ac166
📚 Update QueryBool function document
dozheiny Mar 30, 2023
37a9337
Update ctx.md
ReneWerner87 Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ctx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,17 +1081,17 @@ func (c *Ctx) QueryInt(key string, defaultValue ...int) int {
// Get /?name=alex&want_pizza=false&id=
// QueryBool("want_pizza") == false
// QueryBool("want_pizza", true) == false
// QueryBool("alex") == true
// QueryBool("alex", false) == false
// QueryBool("id") == true
// QueryBool("id", false) == false
// QueryBool("name") == false
// QueryBool("name", true) == true
// QueryBool("id") == false
// QueryBool("id", true) == true
func (c *Ctx) QueryBool(key string, defaultValue ...bool) bool {
value, err := strconv.ParseBool(c.app.getString(c.fasthttp.QueryArgs().Peek(key)))
if err != nil {
if len(defaultValue) > 0 {
return defaultValue[0]
}
return true
return false
}
return value
}
Expand Down
8 changes: 4 additions & 4 deletions ctx_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2179,10 +2179,10 @@ func Test_Ctx_QueryBool(t *testing.T) {

utils.AssertEqual(t, false, c.QueryBool("want_pizza"))
utils.AssertEqual(t, false, c.QueryBool("want_pizza", true))
utils.AssertEqual(t, true, c.QueryBool("name"))
utils.AssertEqual(t, false, c.QueryBool("name", false))
utils.AssertEqual(t, true, c.QueryBool("id"))
utils.AssertEqual(t, false, c.QueryBool("id", false))
utils.AssertEqual(t, false, c.QueryBool("name"))
utils.AssertEqual(t, true, c.QueryBool("name", true))
utils.AssertEqual(t, false, c.QueryBool("id"))
utils.AssertEqual(t, true, c.QueryBool("id", true))
}

func Test_Ctx_QueryFloat(t *testing.T) {
Expand Down
14 changes: 7 additions & 7 deletions docs/api/ctx.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,8 +1088,8 @@ This property is an object containing a property for each query boolean paramete


:::caution
Please note if that parameter is not in the request, true will be returned.
If the parameter is not a boolean, it is still tried to be converted and usually returned as true.
Please note if that parameter is not in the request, false will be returned.
If the parameter is not a boolean, it is still tried to be converted and usually returned as false.
:::

```go title="Signature"
Expand All @@ -1100,12 +1100,12 @@ func (c *Ctx) QueryBool(key string, defaultValue ...bool) bool
// GET http://example.com/?name=alex&want_pizza=false&id=

app.Get("/", func(c *fiber.Ctx) error {
c.QueryBool("want_pizza") // false
c.QueryBool("want_pizza") // false
c.QueryBool("want_pizza", true) // false
c.QueryBool("alex") // true
c.QueryBool("alex", false) // false
c.QueryBool("id") // true
c.QueryBool("id", false) // false
c.QueryBool("name") // false
c.QueryBool("name", true) // true
c.QueryBool("id") // false
c.QueryBool("id", true) // true

// ...
})
Expand Down