🩹🚨 - fix for redirect with query params

[gilwo]

Redirect middleware not redirecting url with query params

fix redirect to add query params (if applicable) to the redirected url, add tests.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have performed a self-review of my own code
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

[welcome]

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

[nickajacks1]

c.RedirectToRoute actually supports query params, but that only lets you redirect to other routes in the current fiber.App. I wonder if it's worth updating c.Redirect to support them too..

[gilwo]

@nickajacks1 - I looked into c.RedirectToRoute() - i find it cumbersome for the purpose of redirect with query params.
it might be useful in case the redirect require additional (or modified) query params, but this is a new feature if i am not mistaken.
it require a bit more changes in the redirect middleware (especially in the config). my purpose was to fix a flow which appear mandatory in my opinion - the extra complication was not required in my use case.

[nickajacks1]

i find it cumbersome for the purpose of redirect with query params.

You should be able to just set the params to fiber.Map{"queries": c.Queries()} right?
Well, you can't actually do that right now because Redirect doesn't accept those.

Either way, i wonder what the consequence of redirecting query params is..if the same query parameters have different meanings in the original and redirect site, you might get unexpected results (in which case the solution would probably be to do the redirect manually instead of using the middleware)
www.example.com/files.zip?explode=true => www.example.com/bomb?explode=true

This change seems ok, need more opinions though.

[welcome]

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord