Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Fix: Fixed Adapter Otelfiber c.BaseURL() issue #2765

Closed

Conversation

rharshit82
Copy link

@rharshit82 rharshit82 commented Dec 16, 2023

Description

It solves Adaptator + otelfiber issue bug where combination of Adaptator + Otelfiber contrib Middleware, c.BaseURL() returns wrong value (http:// instead of http://localhost:3000)
issue link
Detailed explanation of solution of this issue is mentioned in here

Fixes # (issue)

⚠️ For changes specific to v3, please switch to the v3 Pull Request Template.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes
  • I tried to make my code as fast as possible with as few allocations as possible

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: CONTRIBUTING.md

Copy link

welcome bot commented Dec 16, 2023

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@gaby
Copy link
Member

gaby commented Dec 16, 2023

@rharshit82 Can you check for that field in the unit-tests. Thanks

@ReneWerner87 ReneWerner87 linked an issue Dec 18, 2023 that may be closed by this pull request
3 tasks
@ReneWerner87
Copy link
Member

@rharshit82 we are only waiting for an extension of the unittests for the new functionality, otherwise it is not guaranteed that after each code update the functionality works as expected and it can lead to errors, which we want to prevent directly during the initial implementation

@ReneWerner87
Copy link
Member

closed by #2772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: Adaptor + otelfiber issue
3 participants